Fix Crafter bypass#45
Open
SanderGott wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that players could bypass craftPermission by using the Crafter block. Found
Can see that the build targets paper version
1.14.4, which from what I can see don't include the function. This causes the event handler to crash before reachingsetCancelled(true), allowing players to bypass. Fixed by removingisEmpty()and replacing withresult == null || result.getType() == org.bukkit.Material.AIR, which should work across all API versions.Now this could be an issue with my environment/setup, so if the issue isn't reproduceable please notify me and I'll close the PR. If it actually is a bug I thought I might as well push the fix I did.