Improve search

[HomesGH]

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)
• ✅ New feature (change that adds functionality)
• ✅ Breaking change (causes existing functionality to change)
• ✅ Refactor (significant modification to existing code)
• ✅ Documentation (non-code change)
  A little bit of everything

Overview

This PR tackles:

• Attributes not searched by default? #4696
• Ability to search *all* text, simply #7967

(Fixes #4696, Fixes #7967)

The search functionality is improved with this PR. The default search (without stating field specifier, e.g., u:) is extended to include almost all fields (title, username, password, url, notes, additional attributes, attachments (filename not content) or tags). The skipProtected variable, which was not really used until now, is renamed to includeProtected and connected to a new option ("Include protected fields"). Without this option set, the password and protected additional attributes are excluded from the default search. To clarify that search options are available, the symbol was changed.
Important: The default behavior was changed from including protected fields by default to NOT include protected fields when searching. When searching for passwords (p:XXX), the new option is not considered since stating p: explicity shows the user's wish to search the (protected) password field.

The behavior of * which served both as modifier and wildcard was changed by introducing a new option "Regular expression" so that * is now solely a wildcard. This prevents weird behavior like *test (regex) vs test* (wildcard).

New search terms for has: was introduced:

• has:passkey
• has:expiration (Fixes Add has:expiration to search terms #10584)

Added a default search for entries with passkey:

The documentation was adjusted accordingly and the already existing feature to search within a specific additional attribute using an underscore (_) was added to it.

Screenshots

Testing strategy

• Manual testing on Linux
• Unit tests

Open questions

• Since the default behavior of including protected values changed, searching for * with the "Include protected fields" option NOT set, leads to an empty list. This is not the case for, e.g., t:*. The issue is here the parser in combination of the role of * being both a modifier and a wildcard. When just searching for *, it is a modifier. When prepending characters, * is a wildcard. It feels like a bug... --> Fixed by new option to set regex instead of * modifier.
• The behavior of an empty term (e.g., t:) being related to the includeProtected variable seems a bit odd. --> Fixed to be independent of includeProtected setting
• The unit tests TestEntrySearcher and TestGui need to be adapted

[droidmonkey]

I would like to see the original search icon preserved and add the options icon to the right hand side where the help icon is.

[HomesGH]

I have moved the search options icon and menu to the right and reintroduced the search icon:

I have edited the initial PR description to reflect the current state of this PR.