Conversation
|
Use our wrapper around QMessageBox, MessageBox |
|
@droidmonkey The test coverage fail is from a test that I seemingly do not have locally, which I find odd, including there being 51 tests in the test suite and only 46 locally. I would suggest having them match to make the process of pull requests more efficient. Where exactly do I even find out why this specific test failed? Also, running make format in the build directory changes a lot of things in unrelated files, most of which are just adding a space between closing parentheses and starting squiggly brackets in class definitions. I am fairly certain this is unwanted. Should I just commit it with these changes as well or manually undo them? |
|
Just stop work, we will take it from here. Suggest you update your llvm tools, specifically clang_format You may need to add |
Added a warning message box if the password has been modified (to avoid double warnings) and there is a space at the beginning and/or end of the password (leading/trailing spaces).
Fixes #11023
Screenshots
Testing strategy
I tested it with both new and existing entries as well as making sure that it does not ask twice when the password has not been modified. All tests pass.
Type of change