Fix snap build to use latest format - #13728
Open
droidmonkey wants to merge 1 commit into
Open
droidmonkey wants to merge 1 commit into
droidmonkey wants to merge 1 commit into
Conversation
- add x11-related libs to make the program functional. - additional metadata - remove desktop-launch
droidmonkey
requested review from
phoerious
and
a balanced review from Copilot
September 30, 2026 11:00
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Removing the separate autostart declaration unintentionally changes login-start behavior.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates Snap packaging for Qt 6 and newer Snapcraft metadata.
Changes:
- Uses the
kde-neon-6extension. - Adds package metadata and X11 runtime dependencies.
- Updates desktop integration configuration.
| File | Description |
|---|---|
snap/snapcraft.yaml |
Modernizes Snap metadata, Qt extension, and dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| extensions: [kde-neon] | ||
| plugs: [home, unity7, network, network-bind, removable-media, raw-usb, password-manager-service, browser-native-messaging] | ||
| autostart: org.keepassxc.KeePassXC.desktop | ||
| desktop: usr/share/applications/org.keepassxc.KeePassXC.desktop |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13728 +/- ##
===========================================
- Coverage 63.33% 63.27% -0.06%
===========================================
Files 388 388
Lines 41288 41288
===========================================
- Hits 26147 26121 -26
- Misses 15141 15167 +26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
phoerious
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the snap package to use Qt6 and the latest format. Needed to pull in additional X11 packages to support newer builds.
Testing strategy
Compiled on Launchpad and pushed to beta channel.
Type of change