feat(review): add runner.ts, claude-run.ts, copilot-run.ts#162
Merged
Conversation
Implement the ReviewRunner interface and per-agent runner implementations for the review script. Claude runner parses stream-json to detect errors; Copilot runner passes prompt as CLI arg with a 128 KB guard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
Owner
Author
|
[Baton Reviewer] pass — no actionable issues found; this PR is ready for human review. |
keinstn
commented
Jun 24, 2026
keinstn
left a comment
keinstn
left a comment
Owner
Author
There was a problem hiding this comment.
4 findings across the two new runner files. The --allow-tool=* flag name is the most urgent — it diverges from the production adapter and will silently misconfigure the agent.
keinstn
commented
Jun 24, 2026
keinstn
left a comment
keinstn
left a comment
Owner
Author
There was a problem hiding this comment.
No tests for the new runner files. scripts/triage/ has 5 test files covering analogous logic — scripts/review/ should follow the same pattern.
- use --verbose in claude review runner - use --allow-all-tools, apply --deny-tool, and validate copilot result exitCode - add runner tests for command construction and result parsing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/review/runner.tswithReviewRunnerinterface andcreateRunner(config)factoryscripts/review/claude-run.ts— Claude Code runner that passes prompt via stdin, usesstream-jsonoutput, and throws onis_error: truescripts/review/copilot-run.ts— Copilot runner that passes prompt as CLI arg with a 128 KB guard, runs in the workspace directoryCloses #153
Test plan
npm run typecheckpassesnpm run lintpasses🤖 Generated with Claude Code