fix(triage): skip parent issues with sub-issues before evaluation#169
Merged
Conversation
Add `hasSubIssues: boolean` to `TriageIssue` and populate it via a single `fetchSubIssueInfo` call that detects any sub-issues (open or closed). Filter out parent issues in `scripts/triage/index.ts` before passing to the evaluator, logging each skipped issue at info level. Closes #166 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
keinstn
commented
Jun 24, 2026
keinstn
commented
Jun 24, 2026
- Set `hasSubIssues: true` when the `/sub_issues` REST call returns non-200 or a malformed body, so parent-check failures are treated as blockers rather than silently assumed to be leaf issues. - Add `hasSubIssues: false` to the `makeIssue` factory in `test/triage-evaluator.test.ts` so the fixture satisfies the full `TriageIssue` shape. - Update the two error-case tests in `triage-fetcher.test.ts` to assert `hasSubIssues: true` and rename them to reflect the fail-closed intent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
[Baton Reviewer] PR reviewed: implementation matches issue #166 and is ready for human review. |
keinstn
commented
Jun 24, 2026
keinstn
commented
Jun 24, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasSubIssues: booleantoTriageIssueinscripts/triage/fetcher.tsfetchOpenSubIssues+ separatehasAnySubIssueswith a singlefetchSubIssueInfothat detects any sub-issues (open or closed) in one API call and also returnsopenSubIssuesfor the open oneshasSubIssues === trueinscripts/triage/index.tsbefore passing to the evaluator, logging each skipped issue at info levelIssues with any sub-issues (open or closed) are parent/umbrella issues and should never be assigned to an agent. This is a deterministic rule enforced in code rather than left to LLM judgment.
Fixes #166
Test plan
npm run test— all 337 tests passnpm run typecheck— cleannpm run lint— cleanhasSubIssues=trueand are filtered out with an info log🤖 Generated with Claude Code