fix(postgres): batch pg push comparison reads (#331)#754
Merged
Conversation
roborev: Combined Review (
|
Member
|
awesome, thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/postgres/push.gounchanged for this PR, and batch the PostgreSQL-side comparison reads used to decide whether a candidate session can be skipped.internal/postgres/push_fingerprint.gofor message aggregates, message content hashes, role/time fingerprints, message flags, message system ordinals, token fingerprints, tool-call aggregates, tool-call fingerprints, and usage fingerprints, with chunking inside the helper when session counts exceedANY($1)practicality.internal/postgres/push_test.goandinternal/postgres/push_fingerprint_test.goto cover the new batch-driven skip decision path and helper behavior with empty inputs.Scope
internal/postgres/push.go,internal/postgres/push_fingerprint.go,internal/postgres/push_test.go, andinternal/postgres/push_fingerprint_test.go.Notes
Fixes #331