Draft: Look at diff for just using ticks in public kernel api - #16
Draft
kent-mcleod wants to merge 1 commit into
Draft
Draft: Look at diff for just using ticks in public kernel api#16kent-mcleod wants to merge 1 commit into
kent-mcleod wants to merge 1 commit into
Conversation
constraints that change: - max/min budget/period constraints are much less because there isn't overflow issues in conversion between ticks and us - System doesn't perform division operations. Division implementation for 64bit values doesn't have to be validated on each platform/timer frequency used. build constants that need changing: - CONFIG_BOOT_THREAD_TIME_SLICE - TIMER_PRECISION - ksDomSchedule.length - CLOCK_SYNC_DELTA - CONFIGURE_KERNEL_WCET Runtime API changes: - SC_Configure would take ticks - consumed return value would be in ticks
|
We already have a ticks version of TIMER_PRECISION: TIMER_OVERHEAD_TICKS. But those config values are constant and could be calculated at compile time. So it's really only SC_Configure that breaks the API. |
|
This is what MCS should have done from the start IMHO. Other than people getting the CLK_MAGIC and CLK_SHIFT wrong, the main problem with doing this conversion in the kernel is mostly on 32-bit platforms with a fractional MHz clock, where that approach just doesn't work because of overflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
constraints that change:
build constants that need changing:
Runtime API changes: