Identity-aware-proxy (IAP) support#117
Conversation
|
looks really good! |
|
@piekay btw does it work with the "Save login info" experimental feature? |
Sadly I don’t see a way to integrate it, since login is being handled by the Webview, but you reminded me of something I forgot to test: I haven’t tested what happens if the session expires… I‘ll test it and share the results here |
|
So it works normally (shows the your session may have expired text). Most Oauth2 solutions allow for indefinite sessions, so the user could configure this server-side, when it comes to "Save login info" |
@piekay nice! so the best thing for now is disabling that save login info option for IAP auth |
I added a change that disables the Option for Users that use OAuth2 and makes it clear that the option will be disabled if OAuth is used. The Indonesian translation isn't up to date, since I don't speak it and I don't want to rely on autotranslation |
|
your commits are cherrypicked into #118 and already on TestFlight, thanks! |
|
closing this as all commits have been cherrypicked to release/2.2 |
2 participants
After a bit of cleanup I think the code is now ready for a pull request. See:
#116
The app now supports custom sources for: username, JWT Header and Authentication cookie. This code automatically extracts the cookies needed for login from the webview thus allowing near seamless oauth2 experience.
Tested with:
Oauth2-proxy and Nginx
Should work with:
Nearly all oauth2 iap solutions