feat: Support older java versions, preserving functionality#51
Merged
julienvincent merged 1 commit intoJun 23, 2026
Merged
Conversation
julienvincent
left a comment
julienvincent
left a comment
Contributor
There was a problem hiding this comment.
A small nit, but happen to merge otherwise
Comment on lines
+9
to
+10
| ;; Using Runtime/version instead of reflection for VirtualThreadExecutor to | ||
| ;; ensure GraalVM compilation works correctly |
Contributor
There was a problem hiding this comment.
This comment seems a bit pointless? I'm not really sure what it's trying to say, can you remove?
Contributor
Author
There was a problem hiding this comment.
Basically I was trying to say I didn't use sth like this
(def virtual-threads-supported?
(try
(Class/forName "java.lang.Thread$Builder$OfVirtual")
true
(catch ClassNotFoundException _
false)))Because I think it wouldn't have went well with GraalVM compilation. I'll remove it anyway
ovistoica
force-pushed
the
support-older-java-versions
branch
from
e08192c to
93dce73
Compare
julienvincent
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using java 17 on our build & release VMs which breaks using kmono due to reliance on virtual threads. With this change, virtual threads are only used on Java 21+. As per the comment, using this logic instead of reflection to ensure GraalVM still compiles the cli.
Tested both cli compilation and running on Java 17 and now all work.
Happy to do any further changes if you need it!