fix(vfs,syscall): bound ACL entry-count and xattr name/value copies#129
Merged
Conversation
Exported helpers sliced/multiplied attacker-influenced counts/lengths without a cap (latent — pub APIs, no wired dispatch reaches them today): - posix_acl as_slice / posix_acl_to_xattr: entries[..count] and count*ACL_ENTRY_SIZE with count uncapped -> .min(MAX_ACL_ENTRIES). - nfs_acl lookup / encode_nfsacl: entries[..count] uncapped -> .min(NFSACL_MAX_ENTRIES). - listxattr list(): sum of name lengths -> saturating fold. - removexattr insert_attr: name/value copy_from_slice into fixed buffers without a length bound -> clamp both sides to the buffer length. All conservative; no behaviour change for in-range counts/lengths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latent (unwired exported helpers): posix_acl/nfs_acl
entries[..count]+count*ENTRY_SIZEuncapped ->.min(MAX); listxattr name-length.sum()-> saturating fold; removexattr insert_attr name/valuecopy_from_slice-> clamp to buffer. Gate: clippy -p {vfs,syscall} ✓ + builds ✓ + fmt ✓. Conservative.