Open
Conversation
abrown
force-pushed
the
unused-imports
branch
from
abc45a1 to
b18e298
Compare
This enables additional lints that will catch unused imports and variables (see previous commit).
alexbaden
reviewed
Feb 3, 2026
| - id: debug-statements | ||
|
|
||
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| rev: v0.9.1 |
Contributor
There was a problem hiding this comment.
We may want to keep this the same as upstream to avoid formatting differences when we want to PR code back to them: https://github.com/triton-lang/triton/blob/main/.pre-commit-config.yaml#L21
| @staticmethod | ||
| def make_ttgir(mod, metadata, options): | ||
| pm = ir.pass_manager(mod.context) | ||
| dump_enabled = pm.enable_debug() |
Contributor
There was a problem hiding this comment.
This came from upstream but it's true, we are not using it right now. I think I left it as a placeholder that meant we might want to support dumping debug info via different passes if debugging is available (I might even have that in a branch somewhere).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.