test(scripts): raise ExecuteFlow timeout to fix cold-start flakes#393
Merged
Conversation
Contributor
Contributor
Tests report quick summary:success ✅ > tests: 238, success: 238, skipped: 0, failed: 0 unfold for details
|
The @ExecuteFlow await defaults to 60s. The all_*.yaml sanity-check flows run script tasks that compile/build inside Docker; on a cold CI runner, image pull plus compilation can exceed 60s, leaving the execution RUNNING at the deadline and failing parameter resolution (seen on plugin-script-go). Bump the timeout to PT5M on the heavier runner tests (go, dotnet, deno, bun, php) for headroom while still failing fast on a genuine hang. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
108889d to
31b8ef0
Compare
Malaydewangan09
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raise the
@ExecuteFlowawait timeout from the default 60s toPT5Mon the heavier script runner tests: go, dotnet, deno, bun, php.Why
The
maincheck failed on run 28774084040:@ExecuteFlow's parameter resolver awaits the execution reaching a terminal state, with a default timeout of 60s (PT60S). Theall_*.yamlsanity-check flows run script tasks that compile/build inside a Docker task runner (Go'sall_go.yamlruns twogo runtasks that each compile). On a cold CI runner, image pull plus compilation exceeded 60s, so the execution was stillRUNNINGat the deadline — a cold-start flake, not a regression.Fix
Applied to the runner tests most exposed to cold-start latency. Gives comfortable headroom for image pull + compilation while still failing fast on a genuine hang. All four modules compile (
compileTestJava); go verified previously.jbang, julia, and r don't use
@ExecuteFlow, so they're unaffected.🤖 Generated with Claude Code