Adds "useCurrentBreakpoints" hook#318
Draft
kettanaito wants to merge 1 commit into
Draft
Conversation
kettanaito
commented
Apr 6, 2020
| /** | ||
| * Returns a list of breakpoints that match the current state of the viewport. | ||
| */ | ||
| export default function useCurrentBreakpoints(): string[] { |
Owner
Author
There was a problem hiding this comment.
Returning a list of breakpoint names, because it's possible for multiple breakpoints to match a single state of the viewport:
Layout.configure({
breakpoints: {
portrait: {
orientation: 'portrait'
},
mobile: {
maxWidth: 576
}
}
})On a viewport with the width of 500px both portrait and mobile breakpoints would match.
Owner
Author
|
I'm currently in doubt whether this hooks bears any user value. Discussion in #279 |
d766304 to
dfaa1e8
Compare
dfaa1e8 to
991e8aa
Compare
991e8aa to
7513b27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
useCurrentBreakpointshookIssues
Release version
Contributor's checklist
masteryarn verifyto see the build and tests passuseBreakpointChangehook