Add dedicated exception handling for filter method conflicts - #63
Merged
Conversation
- Add test for single method conflict detection - Add test for multiple core methods conflicts - Add test to verify non-conflicting methods work correctly - Add test for exception message formatting - Move conflict check outside attempt() block to ensure exception is thrown - Fix Invokable engine to check for conflicts before executing filter methods Closes: Exception handling for method name conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect filter methods that conflict with core
Filterablemethods and report them using a dedicated exception.Changes
FilterableMethodConflictExceptionapply,filter, andgetBuilderattempt()so configuration errors are never silently swallowed$mentorsas the recommended alternative