Refactor AttributeContext to use the Engine context - #64
Merged
Conversation
…ecture (#52) * refactor(attributes): replace query+state deps with Engine. * refactor(AttributePipeline): remove unused parameter from constructor * refactor: remove unused AttributeHandler implementations * refactor(engines): replace query deps with Engine context * fix(Required): update error message to use payload field instead of context state key * refactor(Scope): update query retrieval method and remove scope applied flag * refactor(CastAttributeTest): mock Engine in AttributeContext for improved test isolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify
AttributeContextby replacing the generic query and state dependencies with the active Engine and Payload instances.Changes
EnginePayloaddirectly accessible to attributes