fix: Restore blurURL for image blur placeholders across pages - #136
Open
kevinreber wants to merge 2 commits into
Open
fix: Restore blurURL for image blur placeholders across pages#136kevinreber wants to merge 2 commits into
kevinreber wants to merge 2 commits into
Conversation
The blurURL was being explicitly overridden with an empty string in multiple page components, causing images to show skeleton loaders instead of blur placeholders while loading. This fix: - Removes blurURL: "" overrides in ExplorePage, SetDetailsPage, and CollectionDetailsPage - Adds missing blurURL generation to getSet.ts - Adds blurURL to collections route image formatting - Updates SetImage interface to include blurURL type Images now properly use the blur placeholder URLs from the data sources instead of showing black skeleton loaders during image load. https://claude.ai/code/session_017kkis554M1snzH3Az7RsNo
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
The explore.$imageId route doesn't use defer, so the loader data is already resolved when the component renders. Using Await/useAsyncValue with non-deferred data caused useAsyncValue to return undefined, resulting in a blank detail page. This fix: - Removes Await and Suspense wrappers since data is not deferred - Passes imageData directly as a prop to ExploreImageDetailsPageAccessor - Adds null check for missing image data - Removes unused Loader2 import https://claude.ai/code/session_017kkis554M1snzH3Az7RsNo
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blurURL was being explicitly overridden with an empty string in
multiple page components, causing images to show skeleton loaders
instead of blur placeholders while loading. This fix:
CollectionDetailsPage
Images now properly use the blur placeholder URLs from the data sources
instead of showing black skeleton loaders during image load.
https://claude.ai/code/session_017kkis554M1snzH3Az7RsNo