Parallel k-mer counting: 1 thread per sample#102
Closed
standage wants to merge 4 commits into
Closed
Conversation
This was referenced Aug 4, 2017
Collaborator
Author
|
Closed in favor of #107. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most time intensive steps of kevlar,
kevlar countandkevlar novel, are in need of some significant speedup. This PR is investigating a simple change so that the 3-4 samples in a simplex are loaded in parallel in dedicated threads. Testing on small sample files gives the approximate speedup expected. But after having gone through this trouble, it's probably worth taking a closer look at how khmer handles multithreaded loading for a single sample, which would give much more flexibility and (hopefully performance increase) when more threads are available.