Skip to content

Conversation

@KillerInstinct
Copy link
Contributor

  • WMI_Next hook added, which functions similar to WMI_Get for async related APIs on the backend (e.g. PowerShell cmdlet Get-CimInstance instead of Get-WmiObject
  • Added initial spoofery for WMI
  • Couple more hooks (to be officially added by Kevin at some point)
  • Hopefully fixed weirdness with existing WMI hooks and NOTAIL shenanigans, just converted them to HOOK macros and we now log prior to calling the hook (which is effectively the same as NOTAIL)

Note: This PR is in a draft until @kevoreilly has time to add yara for CreateInstanceEnum/CreateInstanceEnumAsync

- WMI_Next hook added, which functions similar to WMI_Get for async related APIs on the backend (e.g. Get-CimInstance instead of Get-WmiObject
- Added initial spoofery for WMI
- Couple more hooks (to be officially added by Kevin at some point)
- Hopefully fixed weirdness with existing WMI hooks and NOTAIL shenanigans, just converted them to HOOK macros and we now log prior to calling the hook (which is effectively the same as NOTAIL)
@gemini-code-assist
Copy link

Summary of Changes

Hello @KillerInstinct, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the system's capabilities for interacting with and manipulating Windows Management Instrumentation (WMI). It introduces a new hook for asynchronous WMI enumeration, implements a comprehensive WMI data spoofing mechanism to alter system information reported via WMI, and refines the existing WMI hooking infrastructure. These enhancements aim to provide more robust control and stealth over WMI interactions, improving the system's ability to present a modified view of the environment.

Highlights

  • WMI_Next Hook Added: A new WMI_Next hook has been introduced to handle asynchronous WMI API calls, similar to WMI_Get, enabling interception and modification of enumerated WMI properties.
  • Initial WMI Spoofing: Initial spoofing logic has been implemented for various WMI properties, including GPU name, physical memory, logical disk size, CPU core count, GPU RAM, and BIOS version, to alter reported system information.
  • Hook Macro Conversion and Logging Refinement: Existing WMI hooks (WMI_ExecQuery, WMI_ExecMethod, etc.) have been converted from HOOKDEF_NOTAIL to HOOKDEF macros, ensuring logging occurs before the original function call, and logging for WMI_Get has been refined to filter out common properties.
  • Expanded WMI Hook Coverage: Several new WMI functions, including WMI_ExecQuery, WMI_ExecQueryAsync, WMI_ExecMethod, WMI_ExecMethodAsync, WMI_GetObject, and WMI_GetObjectAsync, are now properly hooked and logged.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant improvements to WMI hooking, adding a new hook for WMI_Next and initial data spoofing capabilities. The refactoring of existing WMI hooks to call the original functions is a great improvement for correctness and stability. My review focuses on some critical null-pointer safety issues that could cause crashes, and a few suggestions to improve code maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant