Open
Conversation
Contributor
|
what is the advantage of using withdraw logic for ERC20 tokens? Is the reentrance problem applicable to non-payable functions? Also, in that case wouldn't it be better to use the approve mechanisms and then have the merchant use transferFrom instead? This way we would at least avoid to duplicate the data already held by the ERC20 contract itself (thus we wouldn't have two sources of truth) |
Author
|
We could use approval mechanism and lock the tokens based on how much is approved, but I dont see any technical difference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.