refactor(web): generalize SearchQuotientSpur parent requirements 🚂 #14987
+525
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
30f660a to
604ee6c
Compare
jahorton
changed the base branch from
refactor/web/search-batcher
to
change/web/remove-duplicate-path-filtering
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
604ee6c to
1f69bba
Compare
jahorton
force-pushed
the
change/web/remove-duplicate-path-filtering
branch
from
3f3382a to
1f3b029
Compare
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
1f69bba to
7b67bc5
Compare
jahorton
force-pushed
the
change/web/remove-duplicate-path-filtering
branch
from
1f3b029 to
9c197bd
Compare
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
f0978aa to
c28bb20
Compare
mcdurdin
approved these changes
Nov 15, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
I think this is okay. It's very hard to tell if there are logic changes at all. But LGTM
jahorton
force-pushed
the
change/web/remove-duplicate-path-filtering
branch
2 times, most recently
from
86fc4ef to
8043ef3
Compare
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
d685e34 to
09157d7
Compare
jahorton
changed the title
jahorton
added a commit
that referenced
this pull request
Jan 7, 2026
…nstructor This has been factorized out of #14987 for ease of review. Build-bot: skip build:web Test-bot: skip
jahorton
added a commit
that referenced
this pull request
Jan 7, 2026
…nstructor This has been factorized out of #14987 for ease of review. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
09157d7 to
ec60680
Compare
jahorton
changed the base branch from
change/web/remove-duplicate-path-filtering
to
refactor/web/replace-addInput-with-constructor
jahorton
added a commit
that referenced
this pull request
Jan 7, 2026
This was formerly part of #14987 and has been extracted for ease of review. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
ec60680 to
bc23b7b
Compare
jahorton
changed the base branch from
refactor/web/replace-addInput-with-constructor
to
refactor/web/search-result-node-access
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
bc23b7b to
aa538c5
Compare
jahorton
added a commit
that referenced
this pull request
Jan 7, 2026
These changes were previously part of #14987 and have been extracted for ease of review. Build-bot: skip build:web Test-bot: skip
jahorton
changed the base branch from
refactor/web/search-result-node-access
to
refactor/web/local-input-cost-heuristic
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
aa538c5 to
5adf510
Compare
As an upcoming goal is to introduce a new SearchQuotientNode type that will assist with context-caching across multiple tokenizaitons, it is wise to generalize SearchQuotientSpur and functions utilizing it to accept any SearchQuotientNode-implementing type as its parent. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
5adf510 to
28ded16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧
As an upcoming goal is to introduce a new SearchQuotientNode type that will assist with context-caching across multiple tokenizations, it is wise to generalize SearchQuotientSpur and functions utilizing it to accept any SearchQuotientNode-implementing type as its parent.
Build-bot: skip build:web
Test-bot: skip