test(common): better group baseline tests 🧪 🎼 #15348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
web/
linux/
common/
linux/engine/
test
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
ermshiperete
commented
Dec 12, 2025
| 'k_052___nul_and_index.kmn', // js only | ||
| 'k_055___deadkey_cancelled_by_arrow.kmn', | ||
| 'k_0000___null_keyboard.kmn', | ||
| // 'k_0103___vkey_input__shift_ctrl_.kmn', |
Contributor
Author
There was a problem hiding this comment.
Looks like I accidentally added the commented tests to the list in #15341- they are working fine for .js keyboards.
Member
There was a problem hiding this comment.
I am slightly confused - if they are working fine, why are they commented here and not removed?
ermshiperete
force-pushed
the
test/common/baseline
branch
2 times, most recently
from
eba453f to
0c72475
Compare
github-actions
bot
added
developer/
developer/compilers/
core/
ermshiperete
force-pushed
the
test/common/baseline
branch
from
0c72475 to
77e050e
Compare
ermshiperete
changed the title
This change groups similar tests together. Also update `build.sh` to compile .js files. Follow-up-of: #15341 Test-bot: skip
ermshiperete
force-pushed
the
test/common/baseline
branch
from
77e050e to
6de40e9
Compare
mcdurdin
approved these changes
Dec 21, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM, it's a little bit like busy-work but probably a good refactor.
| 'k_0810___nul_and_index', | ||
| 'k_0811___if_and_index', | ||
| 'k_0812___nul_and_contextex', | ||
| # Skipped: 'k_0813___deadkey_cancelled_by_arrow', |
Member
There was a problem hiding this comment.
Suggested change
| # Skipped: 'k_0813___deadkey_cancelled_by_arrow', | |
| # TODO-web-core: Skipped: 'k_0813___deadkey_cancelled_by_arrow', |
| 'k_052___nul_and_index.kmn', // js only | ||
| 'k_055___deadkey_cancelled_by_arrow.kmn', | ||
| 'k_0000___null_keyboard.kmn', | ||
| // 'k_0103___vkey_input__shift_ctrl_.kmn', |
Member
There was a problem hiding this comment.
I am slightly confused - if they are working fine, why are they commented here and not removed?
Member
There was a problem hiding this comment.
Can you add an index of what the various groups of tests are intended to be? Your grouping strategy is not entirely clear to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change groups similar tests together. Also update
build.shto compile .js files.Renamed test files, sorted by new name
Renamed test files, sorted by old name
Follow-up-of: #15341
Test-bot: skip