test(web): add option setting/verification to baseline tests 🧪 🎼 #15370
+49
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
mcdurdin
reviewed
Dec 18, 2025
Comment on lines
-71
to
-77
| 'k_0501___options_with_preset.kmn', | ||
| 'k_0503___options_with_save_and_preset.kmn', | ||
| 'k_0504___options_with_reset.kmn', | ||
| 'k_0505___options_double_set_reset.kmn', | ||
| 'k_0506___options_double_set_staged.kmn', | ||
| 'k_0507___options___double_reset_staged.kmn', | ||
| 'k_0508___options___double_reset.kmn', |
Contributor
Author
There was a problem hiding this comment.
They are fixed now, so they are removed from the ToFix list.
Adding the option verification caused another .kmx test to fail because the feature is not yet implemented. Test-bot: skip
mcdurdin
approved these changes
Dec 22, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
At some point we should parameterize the host in page.goto because we may need to move the port
But low pri
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enable some .js tests that are now passing with these changes.
Test-bot: skip