maint(web): escape single quotes in TC service messages 🎼 #15374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
github-actions
bot
added
common/
maint
ermshiperete
force-pushed
the
maint/web/playwright-tc
branch
from
0101508 to
e0b582a
Compare
This fixes a problem where TC shows an error because it can't find the end of the service message for a failed test. Single quotes (and some other characters) have to be escaped with `|'` inside of a message. Build-bot: skip:all build:web Test-bot: skip
ermshiperete
force-pushed
the
maint/web/playwright-tc
branch
from
e0b582a to
0dbbcc4
Compare
rc-swag
approved these changes
Dec 21, 2025
Contributor
rc-swag
left a comment
rc-swag
left a comment
There was a problem hiding this comment.
lgtm
Does getTestResult only get sent to TC. The reason I ask is we aren't sending the error to stdout on bash or something which would expect standard escape '' characters?
mcdurdin
approved these changes
Dec 21, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
I wonder if we have other reporters that need this escaping too?
ermshiperete
added a commit
that referenced
this pull request
Dec 22, 2025
See: https://www.jetbrains.com/help/teamcity/service-messages.html#Escaped+Values. Follow-up-of: #15374 Build-bot: skip:all build:web Test-bot: skip
Contributor
Author
Most reporters already do that. #15384 adds some missing values to |
ermshiperete
added a commit
that referenced
this pull request
Jan 6, 2026
chore(web): escape some additional values in TC service messages See: jetbrains.com/help/teamcity/service-messages.html#Escaped+Values. Follow-up-of: #15374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where TC shows an error because it can't find the end of the service message for a failed test. Single quotes have to be escaped with
|'inside of a message, as well as some other characters.Build-bot: skip:all build:web
Test-bot: skip