Blank display before the SID player's run_prg kick#79
Merged
Conversation
run_prg soft-resets the C64, which has the same reset-latency window reset() already guards with blank_display() — without it, launching the SID player over a previous hires/mhires scene briefly flashes that scene's leftover bitmap RAM before the kernal reinitializes VIC and WaveformScene re-engages its own bitmap mode. Mirrors the guard reset() already uses for the identical class of glitch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 79.64% 79.64%
=======================================
Files 77 77
Lines 15701 15702 +1
Branches 2379 2379
=======================================
+ Hits 12505 12506 +1
Misses 2657 2657
Partials 539 539 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_prg's soft-reset has the same reset-latency windowreset()already guards withblank_display(), but the SID player's_launch_sid_playerkick skipped that guard.Ultimate64API._launch_sid_playernow blanks the display (DEN off) immediately before DMA'ing the SID payload/player/stub, mirroringreset()'s existing guard for the identical class of glitch. TeensyROM is untouched — its vector-swap kick doesn't reset the machine and blanking there would stall its cycle-clean DMA gate (documented elsewhere)._SidPlayerBackend's shared orchestration, so it covers everyrun_sid_playercaller on the Ultimate (WaveformScene, MidiScene's SID paths, and generative scenes withaudio_source = "sid"), not just the reported waveform-to-waveform case.docs/caveats.md's "SID playback uses a C64-side player PRG" section.Test plan
make lint/make typecheck/ full unit suite all pass; updatedtests/test_api.py'sRunSidPlayerTestfixture to track the new pre-flight$D011write separately from the SID-upload DMA sequence it was already asserting on.run_prgtransition cleanly with no errors.