Fix mkl error #244
Merged
Fix mkl error #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@assignUser I had to do this tiny fix, because I was getting a CRAN error. I'd like to merge this, but giving you a chance to take look if you'd like. There was an error in one of the checks, but it had nothing to do with simstudy, so I am going to ignore it. Thanks. |
assignUser
approved these changes
Dec 8, 2025
R/generate_correlated_data.R
Outdated
| } | ||
|
|
||
| assertPositiveSemiDefinite(corMat = cm) | ||
| cm <- ( cm + t(cm)) / 2 # ensure symmetry even with rounding errors - fixes CRAN error |
Collaborator
There was a problem hiding this comment.
My only comment would be that given the number of times this repeated it would make sense to pull it out into a function.
Owner
Author
There was a problem hiding this comment.
I made that change - thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix in
genCorMatto address an issue where very small rounding differences could make correlation matrices appear non-symmetric, preventing some data generation. Matrices are now always properly symmetrized.