Use LONG_BIT to define RADIX_BITS#16
Open
ffontaine wants to merge 1 commit into
Open
Conversation
This allows to avoid having to support each CPU architecture individually. Also, add the necessary defines in the makefile to expose LONG_BIT. Adding those defines end up requiring using <sys/select.h> as we're now using >= POSIX.1-2001 definitions of fd_set and friends. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Signed-off-by: Vincent Fazio <vfazio@gmail.com> Signed-off-by: Bernd Kuhls <bernd@kuhls.net> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Contributor
Author
|
This is a tentative to upstream this patch which has been applied on buildroot side since 2020: https://git.buildroot.net/buildroot/tree/package/ibm-sw-tpm2/0001-Use-LONG_BIT-to-define-RADIX_BITS.patch |
kgoldman
reviewed
Aug 6, 2024
kgoldman
left a comment
kgoldman
left a comment
Owner
There was a problem hiding this comment.
Am I correct that this is Linux only, that the header file and macro don't exist on Windows and perhaps other platforms that are currently supported?
I like the idea, but I don't want to break non-Linux builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to avoid having to support each CPU architecture individually.
Also, add the necessary defines in the makefile to expose
LONG_BIT. Adding those defines end up requiring using<sys/select.h>as we're now using >= POSIX.1-2001 definitions offd_setand friends.