feat: add stickers page to the site - #331
Open
khromov wants to merge 2 commits into
Open
Conversation
Printable sticker sheet (/stickers) and logo export (/stickers/logo), with PNG export via html-to-image. Split out from #182 onto current main.
Closed
Contributor
Mochi review reportTry this PRExpand instructionsgh run download -R khromov/mochi 32598723900 -n mochi-framework-pr -D /tmp/mochi-pr && bun i /tmp/mochi-pr/mochi-framework-pr.tgzDependency reportExpand reportSecurity & licenses
|
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 51739 | 51739 | 0 |
Unchanged: src/**/*.test.ts (23437), src/Mochi.ts (2107), src/{events,log,logger}.ts (469), src/extensions.ts (318), src/image/** (1734), src/middleware/** (80), src/{types.ts,*.d.ts} (949), src/web-components/** (719), src/debug-bar/** (3436), src/templates/** (1720), Other (16770).
packages/docs
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 6462 | 6462 | 0 |
Unchanged: Docs (6462).
packages/site
| Category | main | PR | Δ |
|---|---|---|---|
Other |
4488 | 4921 | +433 |
| Total | 24083 | 24516 | +433 |
Unchanged: src/demos/** (13793), src/components/** (3033), src/lib/** (2743), src/stores/** (26).
packages/demos
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 3058 | 3058 | 0 |
Unchanged: src/hn/** (1066), Other (1992).
packages/minimal
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 550 | 550 | 0 |
Unchanged: Other (550).
packages/minimal-rsvelte
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 548 | 548 | 0 |
Unchanged: Other (548).
packages/support
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 3294 | 3294 | 0 |
Unchanged: src/**/*.test.ts (634), src/admin/** (671), src/components/** (84), src/*.server.ts (379), src/{index,routes}.ts (236), Other (1290).
packages/shared
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 44 | 44 | 0 |
Unchanged: Other (44).
packages/mochi-rsvelte
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 177 | 177 | 0 |
Unchanged: Other (177).
packages/mochi-svelte-shaker
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 184 | 184 | 0 |
Unchanged: Other (184).
packages/cli
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 1066 | 1066 | 0 |
Unchanged: src/**/*.test.ts (440), src/cli* (165), src/{create,templates,utils}.ts (277), Other (184).
packages/video-animations
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 646 | 646 | 0 |
Unchanged: src/{frame,anim,theme}.ts (389), src/{render,render-worker,generate}.ts (182), Other (75).
packages/msgpackr-extract-stub
| Category | main | PR | Δ |
|---|---|---|---|
| Total | 29 | 29 | 0 |
Unchanged: *.test.ts (22), Other (7).
Wrap /stickers and /stickers/logo in the DEVELOPMENT conditional so they 404 in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the stickers page to the site, split out cleanly from #182.
What's here
/stickers— printable sticker sheet with a selectable grid; exports a high-res PNG viahtml-to-image./stickers/logo— logo + wordmark export page.packages/site/src/stickers/(Sticker,StickerExport,StickerLogo,StickerLogoExport), the base64dangodata URI, and the sourcedango.png/noise.pngassets.html-to-image@1.11.13added topackages/site.packages/site/src/routes.ts.Why a new PR
This branch is cut fresh from
main. #182 (wip: stickers page) was 172 commits behind and bundled three features that have since landed onmainindependently — the named-image-sizes rewrite, cache invalidation, and theHero.svelteheader extraction — so merging it would have reverted that work. This PR carries only the sticker content.Closes #182.
Verification
/stickers/and/stickers/logo/return 200 and hydrate with no console errors.bun run checkspasses.