docs(backlog): log the release-apps blind spot and the superseded-PR rule - #444
Merged
Merged
Conversation
…rule B35: release-apps.yml only triggers on v*.*.* tags, so no PR ever runs it — #438 bumped setup-java to v6 there, which turns on JDK signature verification by default. Same class as B31: a workflow nothing exercises. B36: closing #428 as superseded would have dropped a real fix. #360 was a squash of an earlier point on the same branch, so two later commits were never in it. Records the rule that caught it — merge main, then diff --stat before closing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two out-of-scope findings from clearing the open-PR queue (#442, #439, #438, #337, #443), logged per DoD §7. Documentation only — no source, schema, workflow or dependency changes.
B35 —
release-apps.ymlis never exercised by any PRIt triggers only on
push: tags: v*.*.*. TheWorkflow files are validgate added in #441 parses the YAML but does not run it. #438 just bumpedactions/setup-java5 → 6 in that file, and v6 includes "Set default signature verification for supported distributions" — JDK signature verification now on by default.Low probability of breaking, since the step pins
distribution: temurinandjava-version: "17". But if it does break, it breaks while cutting a release, on theapps/shelldesktop/mobile build. Same class as B31, whereperf-k6.ymlfailed on every push for weeks because nothing looked at it.shell-check.ymldoes not use Java, so it provides no cover.B36 — measure the residual delta before closing a PR as superseded
#428 was closed as "superseded by #360". True for 14 of 15 files. But #360 was a squash of an earlier point on the same
oak-maxwellbranch, so two later commits —0a663a56("make Phase 0 measurements reproducible") and64702033— were never part of it, and were dropped when the branch was deleted.What was dropped was a real fix:
tags: { scenario: 'detail' }overrides the tag k6 derives from the scenario name, leavinghttp_req_failed{scenario:detail_throughput}— the sub-metric its own threshold targets — with no samples, so the threshold could not fail. Another "guard that looks present and never fires", like B31.Caught by merging
maininto the branch and runninggit diff origin/main HEAD --stat, which reported exactlyapps/cms/k6/load-items.js | 1 -. Salvaged in #443 (merged), so B36 is logged asfixedwith the rule recorded: an empty diff is what "superseded" means; a non-empty one goes out as its own PR rather than reopening a PR whose title describes work that already landed.Verification
node scripts/check-registry-numbering.mjs— Setup Impact Registry 114 rows, backlog 34 rows, all ids uniquen/awith the six questions answered (DoD §2)