docs(review): G1 independent acceptance record on main (C-03)

[khuepm]

Summary

Independent lane-C (C-03) verification of the G1 approval-governance fix for #453 on current main.

• Pinned/verified SHA: 9bb14b1cd24e6542a492c65ccb21278694ea6e73 (base of this PR: 6717182bdaab400e11407b3a47bdf02a8c35dc3e — delta 9bb14b1c..6717182b is docs/examples only, zero apps/cms/packages changes, so evidence applies to current tip)
• Head SHA: 36eaa065df5bf2a534b8bd6621ea350a318b62e4
• Changed paths: docs/review-agent/2026-09-14-g1-main-9bb14b1c.md (review record only — no production code touched)
• Isolated worktree: /Users/khuepm/workplace/AI/Lumibase-c03 @ feature/453-c03-verification
• Disposable infra: PostgreSQL 16 (port 55440, db lumibase-g1-verify) + disposable Redis; no shared/starter DB used

Refs #453

Evidence (reviewer-run, real Postgres 16 + Redis)

Suite	Result
G1 focused (7 files: execution, concurrency, sweeper, failed-outcome, missing-service, reviewer, service-touch)	59 passed, incl. 22 real DB-integration tests, 0 skips
Wider approval/harness/reviewer/capability surface (22 files)	98 passed
Skip-gate (no DATABASE_URL)	3 files / 22 tests explicitly skipped — not silently passed
Fail-fast (dead DATABASE_URL)	exit 1 — loud failure, #427 contract held
Golden-path + upgrade-path E2E (real HTTP/PG/Redis, setup wizard → login → content lifecycle → tenant isolation)	2 passed
pnpm -F @lumibase/cms typecheck	exit 0
Full pnpm test (pre-commit hook, all workspaces)	green on commit 36eaa065 (cms: 2737 passed / 105 skipped)

Full per-acceptance-criterion mapping, DoD review, commands/versions/exit codes: see the review record.

Findings

• All 10 prior review findings from the fix(agent): approval decision must execute or resume the governed action #456 rounds verified fixed in source on 9bb14b1c (double-claim 409, reviewer races, stranded deciding claims, unsafe pending reset, sweeper revive, touch-tracking gaps, DB-suite silent-pass).
• effective-capability-service (PR fix(cms): unknown X-Lumi-Site header crashes the API via audit-log FK violation #473, landed post-fix(agent): approval decision must execute or resume the governed action #456 in the pinned delta) confirmed dormant — no callers in the decide path; harmless to G1.

Unverified / limitations (exact-file proposals in the record, not fixed here — verifier lane)

1. Kill-switch deny at approve boundary — wired in runClaimedApproval, unit-tested in isolation; no behavioral test drives frozen-site + approve → denied/claim-released.
2. Cancelled-run approve denial — same: mechanism present, no boundary test.
3. Setup Impact Registry — no row for the G1 approval-execution change (DoD §2 wants explicit row or justified n/a).
4. API spec — docs/en/api/hono-api-spec.md lacks rows for /agent/approvals/:id/decide + /reopen.
5. Deploy CMS workflow failed on last 3 main runs (staging health-check HTTP 500) — pre-existing infra issue (Hyperdrive/PG class, predates this work), not G1-related.

Verdict

See record for the full verdict. This PR is the review artifact — do not merge/close unilaterally; it awaits reviewer sign-off on #453 per the lane-C protocol. No auto-close keywords used deliberately.

Generated with Devin

[khuepham-tp]

🔎 Reviewer — round 2 record added (head 2f534674)

Added docs/review-agent/2026-09-15-g1-main-6717182b.md: the C-03 acceptance re-pinned from 9bb14b1c to the current main tip 6717182b (delta = docs/tutorials + examples/nextjs-blog only, zero G1 surface), re-run on a new disposable postgres:16 (port 55441) because the round-1 container was destroyed mid-session.

Closes three limitations round 1 recorded:

• full @lumibase/cms suite run locally — 2836/2842 tests, 345/348 files; the 3 failing files are characterized as shared-DB/order/machine-speed baseline issues (policy-loader passes serially, golden-path passes on a virgin DB, user-enum.timing times out at 600 s even alone and reports a vacuous pass in CI);
• AC-1 measured rather than inferred, via a temporary real-PG probe with a SchemaService spy (park → 0 calls, ids resolve, run parked; approve → exactly 1 call) — probe deleted, tree clean;
• pnpm check:all exit 0 recorded.

Verdict unchanged: G1 ACCEPTED at 6717182b. G-C (API spec rows, EN+VI) and G-D (setup-impact n/a row) confirmed independently as DoD gaps; two new backlog proposals G-E (Studio getApiBaseUrl() class, 20 files, pre-existing since 326b3837) and G-F (shared-DB suite fragility + pre-#427 vacuous-pass shape). Full table on the issue: #453 (comment)

No production file touched; no merge/closure/release authorized.

[khuepm]

Gộp vào PR #481 theo quyết định của owner 2026-09-19: một implementer, một reviewer, một PR duy nhất. Toàn bộ commit của PR này đã được cherry-pick sang feature/454-lanes-consolidated và re-author dưới khuepm; không mất nội dung nào. Đóng PR này để tránh hai bề mặt review song song.