Skip to content

fix: download correct yt-dlp for arm64 release build#802

Merged
kieraneglin merged 1 commit intokieraneglin:masterfrom
y-young:patch-1
Sep 28, 2025
Merged

fix: download correct yt-dlp for arm64 release build#802
kieraneglin merged 1 commit intokieraneglin:masterfrom
y-young:patch-1

Conversation

@y-young
Copy link
Copy Markdown
Contributor

@y-young y-young commented Sep 28, 2025

What's new?

N/A

What's changed?

N/A

What's fixed?

TARGETPLATFORM is not set in runner image stage and falls back to linux/amd64 when downloading yt-dlp release binary.

Any other comments?

N/A

  • I am the original author of this code and I am giving it freely to the community and Pinchflat project maintainers

@kieraneglin
Copy link
Copy Markdown
Owner

Thank you for this! Did you have a chance to try it locally?

@y-young
Copy link
Copy Markdown
Contributor Author

y-young commented Sep 28, 2025

Yes I've built one locally: https://hub.docker.com/repository/docker/yyoung01/pinchflat/tags/v2025.9.28/sha256:642e26fd147de3594c76dc96b11d106b9fca786f0cb6a8503f0d8aa91f58565b

Confirmed it's running, but I'm new to this project so still working on the setup.

@kieraneglin kieraneglin merged commit 163e8eb into kieraneglin:master Sep 28, 2025
1 check passed
@kieraneglin
Copy link
Copy Markdown
Owner

For whatever reason, it's not working through GitHub actions (but that's not your fault). I'll have to take a closer look tomorrow 🤙🏻

@y-young
Copy link
Copy Markdown
Contributor Author

y-young commented Sep 28, 2025

Could be some problem with Qemu, I was using the same Dockerfile on an arm sever and it worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants