fix: download correct yt-dlp for arm64 release build#802
Merged
kieraneglin merged 1 commit intokieraneglin:masterfrom Sep 28, 2025
Merged
fix: download correct yt-dlp for arm64 release build#802kieraneglin merged 1 commit intokieraneglin:masterfrom
kieraneglin merged 1 commit intokieraneglin:masterfrom
Conversation
Owner
|
Thank you for this! Did you have a chance to try it locally? |
Contributor
Author
|
Yes I've built one locally: https://hub.docker.com/repository/docker/yyoung01/pinchflat/tags/v2025.9.28/sha256:642e26fd147de3594c76dc96b11d106b9fca786f0cb6a8503f0d8aa91f58565b Confirmed it's running, but I'm new to this project so still working on the setup. |
Owner
|
For whatever reason, it's not working through GitHub actions (but that's not your fault). I'll have to take a closer look tomorrow 🤙🏻 |
Contributor
Author
|
Could be some problem with Qemu, I was using the same Dockerfile on an arm sever and it worked fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new?
N/A
What's changed?
N/A
What's fixed?
TARGETPLATFORMis not set in runner image stage and falls back tolinux/amd64when downloadingyt-dlprelease binary.Any other comments?
N/A