Add explicit constructors

[kimkulling]

Summary by CodeRabbit

• Bug Fixes

  • Added bounds checking to string element access to prevent out-of-bounds errors and improve stability.

• Refactor

  • Enhanced type safety by preventing implicit type conversions in template class constructors.
  • Simplified isEmpty() implementation.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes make two template constructors explicit to prevent implicit conversions (TBitField and TOptional), and enhance TStringBase by adding bounds checking to operator[] with simplified isEmpty() syntax.

Changes

Cohort / File(s)	Summary
Constructor Explicitness include/cppcore/Common/TBitField.h, include/cppcore/Common/TOptional.h	Added explicit keyword to single-argument constructors for both TBitField and TOptional to prevent unintended implicit type conversions.
String Base Improvements include/cppcore/Common/TStringBase.h	Added bounds checking in operator[] to return 0 for out-of-bounds indices; simplified isEmpty() by removing unnecessary parentheses around comparison.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Cleanup interface #37: Modifies TBitField constructor signatures (sets default constructor to =default and adjusts init constructor), directly related to this PR's explicit keyword addition to TBitField.

Poem

🐰 Explicit paths and bounds so tight,
No sneaky conversions in the night,
Safe array access, gentle and clear,
Defensive code brings programmers cheer! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch review/explicit_ctr

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a5f2a8 and 11f2f20.

📒 Files selected for processing (3)

• include/cppcore/Common/TBitField.h (1 hunks)
• include/cppcore/Common/TOptional.h (1 hunks)
• include/cppcore/Common/TStringBase.h (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud