Fix process resource leak

[kimkulling]

• closes Bug: pclose is missing #31

Summary by CodeRabbit

• Bug Fixes
  • Improved file dialog error handling on non-Windows platforms to ensure system resources are properly managed and errors are correctly detected.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0c8fc6a-83f4-4f2d-9251-a55b31d0d7a5

📥 Commits

Reviewing files that changed from the base of the PR and between 9d6dc59 and 14a855a.

📒 Files selected for processing (1)

• src/widgets.cpp

---

Walkthrough

Added pclose() calls to properly close file dialog pipes after fgets() in non-Windows implementations of file dialog functions. The functions now check the return status and return ErrorCode if pipe closure fails.

Changes

Cohort / File(s)	Summary
File Dialog Pipe Cleanup src/widgets.cpp	Added missing pclose() calls in getOpenFileDialog and getSaveFileDialog for non-Windows implementations. Functions now check pipe closure status and return ErrorCode on failure instead of silently using potentially corrupted data.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bugfix/kk/fix_resource_leak_issue-31

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}