Replace RestSharp with UnityWebRequests wrapper to fix WebGL & Replace DLLs to fix CI#17
Open
shubhank008 wants to merge 11 commits into
Open
Replace RestSharp with UnityWebRequests wrapper to fix WebGL & Replace DLLs to fix CI#17shubhank008 wants to merge 11 commits into
shubhank008 wants to merge 11 commits into
Conversation
Add Asmdef link for UniTask in Kinetic.SDK Add debug points for testing Add DEFINES for Webgl Sync code and Async code for other platforms in KinSDK
Use Unity WebRequest interface - https://github.com/jeffreylanters/unity-web-requests Add asmdef reference to UniTask and WebRequest asmdef files to KineticSDK Modify ApiClient to WebRequest methods Update AppApi to modified ApiClient
Create Helper method to convert string dictionary to query parameter string Update ApiClient to use the query parameter string made from queryParams dictionary
Update Transaction API
Adding ContentType Json to APIClient API Call Disable Debug Logs Tested and working in WebGL
…iTask approach for all platforms
BouncyCastle bc-csharp ChaosNacl Solana.Unity.Core which includes Solana.Unity.Keystore Porgrams Rpc Wallet Create Asmdef for all library packages and reference them to KineticSDK asmdef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces RestSharp package with UnityWebRequests to make it Unity-oriented and compatible with all Unity platforms, specially WebGL.
RestSharp does not work in WebGL. Also replaces Task with UniTask as Task/Threading also is not WebGL compatible
--Added on: 25-Jan-2023--
the current state of SDK will not work on CI due to DLL issues, so we had to replace the DLLs with their actual code bases to make it work
Obviously before reaching to this conclusion and solution, had tested to make the DLL work extensively including re-referencing the platforms, etc. but problem seems to be when the DLL were created/exported, they were not targeted/enabled for Linux system
So if you make a build using DLL on windows PC for Linux, it will work
But if you try to make a build using DLL on Linux for any platform (what CI does), it will not work as the DLL will not load
It involves: