Skip to content

Gracefully handle a max_size of 0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamiecobbett wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Gracefully handle a max_size of 0 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/lrucache.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def initialize(opts={})
@ttl = Float(opts[:ttl] || 0)
@soft_ttl = Float(opts[:soft_ttl] || 0)
@retry_delay = Float(opts[:retry_delay] || 0)
raise "max_size must not be negative" if @max_size < 0
raise "max_size must be greater than 0" if @max_size < 1
raise "ttl must not be negative" if @ttl < 0
raise "soft_ttl must not be negative" if @soft_ttl < 0
raise "retry_delay must not be negative" if @retry_delay < 0
Expand Down
3 changes: 2 additions & 1 deletion spec/lrucache_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
it "should raise an exception if :max_size parameter can't be converted to an integer" do
expect { LRUCache.new(:max_size => "moocow") }.to raise_exception
end
it "should raise an exception if :max_size parameter is converted to a negative integer" do
it "should raise an exception if :max_size parameter is converted to a non-positive integer" do
expect { LRUCache.new(:max_size => -1) }.to raise_exception
expect { LRUCache.new(:max_size => 0) }.to raise_exception
end

it "should default :default to nil" do
Expand Down