Skip to content

[pull] master from cefsharp:master - #163

Open
pull[bot] wants to merge 1511 commits into
kinglew:masterfrom
cefsharp:master
Open

[pull] master from cefsharp:master#163
pull[bot] wants to merge 1511 commits into
kinglew:masterfrom
cefsharp:master

Conversation

@pull

@pull pull Bot commented Oct 5, 2019

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull Bot added the ⤵️ pull label Oct 5, 2019
@pull pull Bot added the merge-conflict Resolve conflicts manually label Feb 19, 2020
amaitland and others added 28 commits December 15, 2023 20:07
- Upcoming M120 release
* Add in file paths data to DragData

* Update of CefSharp.Core.Runtime.netcore.cs for adding DragData FilePaths and removal of AcceptLanguageList

---------

Co-authored-by: Michael Bragg <michael.bragg@yahooinc.com>
…position is incorrect in Winform form embedded wpf control. (#4678)

WPF - Fix chinese IMEs ( such as "sogou pinyin", "qq pinyin" etc. ) input window position, In Winform embedded wpf borwser mode.

* Update WpfIMEKeyboardHandler.cs
By default vswhere returns a non-zero error code making our error handling fail
- When running from a library with no RuntimeIdentifier specified, check
  relative to CefSharp.Core.dll in runtimes folder
- LicenseUrl is deprecated
- Stop the dependency bot from complaining. 4.7.0 is only vulnerable on non-windows systems
  so it wasn't actually a problem as CefSharp only runs on windows
* Change Frame identifier from Int64 to String

Issue #4737

* Fix SetCanExecuteJavascriptOnMainFrame frameId parsing

* Add tests

* NetCore Tests - Install missing packages
* Fixed positioning of dropdown.

* Renamed mouse-teleport, adjusted code-style, moved logic to mouse-adjustor, applied codereview.

* Added comments to new class.

* Applied codereview, i.e. renamed teleporting-variables and -comments.

* Added boolean for the state of the popup.

* Set isOpen.

* Optimized adjust-method.

* Added interface for mouse-adjustor.

---------

Co-authored-by: Vogel <vogel@atv-systems.de>
Co-authored-by: Daniel Vogel <daniel.vogel@kinoda.de>
…anup) (#4759)

* WPF - Popup Mouse Transform

- Refactor and performance improvements
- WPF Example - Enable popup transform by default

Issue #2820
because AppVeyor checks out a commit rather than a branch appveyor/ci#1606
amaitland and others added 30 commits March 29, 2026 08:55
* Allow JavaScript binding when browser wrapper cannot be found

* Store JavascriptBindingSettings per Browser and never remove them

This avoids the issue that sometimes browsers are destroyed but then referenced again without them beeing created

* Use dict->Values
…ser settings (#5231)

* Move LegacyBindingEnabled / JavascriptBindingPropertyName to per browser settings

* Stricter test

---------

Co-authored-by: Alex Maitland <amaitland@users.noreply.github.com>
…-line arguments with existing values (#5245)

* Core - Automatically merge `enable-features/disable-features` command-line arguments with existing values
… out

- Prevent accessing resources outside of the root path specified.
- Add Test to verify
This wraps the `CefDownloadItem::IsPaused()` from CEF 144 release.
See the `cef.sdk\cef\include\cef_download_item.h` file.
This exposes the `CefRequestContext::ClearHttpCache(callback)` from CEF 144 release.
See the `cef.sdk\cef\include\cef_request_context.h` file.
* Core - Support Chrome command execution.

- Add `Cef.MapChromeCommandNameToId`.
- Add `IBrowserHost.CanExecuteChromeCommand`
- Add `IBrowserHost.ExecuteChromeCommand`
- Will remove in the short term until we can get these generated as the ids reportedly
  are in a constant state of flux.
…5266)

* Core -  Expose `IsInterrupted` and `InterruptReason` to DownloadItem.
* Core - Add `AddPreferenceObserver` support.
…5281)

* Fix deferred client certificate selection reading freed memory

CefCertificateCallbackWrapper held the offered certificate list as
`const X509CertificateList&`, bound to a stack local built in
ClientAdapter::OnSelectClientCertificate. Once that handler returned the
list was destroyed, so calling Select() at any later point walked freed
memory and threw inside the thumbprint-matching loop, taking the host
process down with it.

CEF explicitly permits answering later. cef_request_handler.h says to
return true and call Select "either in this method or at a later time",
so a wrapper that outlives the handler has to own the list it selects
from. It now holds a heap-allocated copy, freed in the finalizer. A ref
class cannot contain a std::vector by value, hence the pointer. Copying
the vector copies the reference-counted CefX509Certificate pointers, and
those references are what keep the certificates alive.

This is the remaining half of #2948. The comment above the caller reads
"Create a copy of the vector in an attempt to fix #2948", and the copy is
indeed made - but it is then bound by reference, so it dies at the same
instant the original would have.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Remove the redundant certificate vector copy in ClientAdapter

The wrapper takes its own copy in its constructor, so the local copy added
by a51cdd3 in ClientAdapter::OnSelectClientCertificate is now pure
redundancy - two copies where one is needed. Pass `certificates` straight
through instead.

Also refreshes the comment on _certificateList, which described the caller's
stack local that this removes.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: John Hodnik <jhodnik@activu.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Vaibhav Srivastava <vaibhavsri1712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⤵️ pull merge-conflict Resolve conflicts manually

Projects

None yet

Development

Successfully merging this pull request may close these issues.