Skip to content

fix(feedback): bind ratings by response id #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AgentArcLab merged 1 commit into from
Jul 30, 2026
Merged

fix(feedback): bind ratings by response id #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/utils/feedback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export function shouldRenderFeedbackControls(message, isStreaming, isLastMessage
return Boolean(
message?.role === 'model' &&
textValue(message.responseId) &&
textValue(message.eventId) &&
!(isStreaming && isLastMessage),
);
}
Expand Down Expand Up @@ -88,15 +87,11 @@ export function buildUpsertFeedbackPayload({
}
const payload = {
...buildGetFeedbackPayload({ agentId, sessionId, message }),
EventId: textValue(message?.eventId),
Rating: normalized,
Comment: String(comment || ''),
TraceId: textValue(message?.traceId),
RootSpanId: textValue(message?.rootSpanId),
};
if (!payload.EventId) {
throw new Error('Message missing event id');
}
return payload;
}

Expand Down
10 changes: 8 additions & 2 deletions tests/feedback-utils.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ test('feedback utils expose assistant response feedback state', async () => {
),
true,
);
assert.equal(
feedback.shouldRenderFeedbackControls(
{ role: 'model', responseId: 'resp_123' },
false,
true,
),
true,
);

assert.deepEqual(
feedback.normalizeFeedback({
Expand Down Expand Up @@ -81,7 +89,6 @@ test('feedback utils build action payloads for up and down feedback', async () =
AgentId: 'agent-1',
SessionId: 'sess-1',
ResponseId: 'resp_123',
EventId: 'ev_1',
Rating: 'up',
Comment: '',
TraceId: 'trace-1',
Expand All @@ -101,7 +108,6 @@ test('feedback utils build action payloads for up and down feedback', async () =
AgentId: 'agent-1',
SessionId: 'sess-1',
ResponseId: 'resp_123',
EventId: 'ev_1',
Rating: 'down',
Comment: '不准确',
TraceId: 'trace-1',
Expand Down
Loading