-
Notifications
You must be signed in to change notification settings - Fork 110
Read EnOcean Chip ID and module version info #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
henningkerstan
wants to merge
44
commits into
kipe:master
Choose a base branch
from
henningkerstan:read-version-info
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hello @kipe, could you please have a quick look at this pull request? Thanks! |
If the port is busy do not parse anything. Without this I am able to start multiple communicators per port and send a command to it in this short timeframe.
… for opening the file.
Update python-publish.yml Update python-package.yml trying to get pypi upload working logger.warn -> logger.warning fix testing
restructure the folder a little bit use relative imports a few code changes
restructure the folder a little bit use relative imports a few code changes
replaced most %-string formatting with f-strings
added: - EEP A5-20-06: HVAC Components,Harvesting-powered actuator with local temperature offset control - EEP D2-01-0E: Electronic switch with Local Control - EEP D2-01-12: Electronic switch with Local Control - EEP A5-04-02: Temperature and Humidity Sensor - Range -20°C to +60°C and 0% to 100% - EEP A5-04-04: Temperature and Humidity Sensor - Range -40°C to +120°C 12bit-measurement and 0% to 100% - EEP A5-08-02: Light, Temperature and Occupancy Sensor - Range 0lx to 1020lx, 0°C to +51°C and Occupancy Button - EEP A5-08-03: Light, Temperature and Occupancy Sensor - Range 0lx to 1020lx, 0°C to +51°C and Occupancy Button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested change will add two (read-only) properties to the
Communicatorclass:chip_id()which returns the modules chip id (if successful) andversion_info()which returns the modules version info (if successful).The version info is a new data structure, which is defined in the
VersionInfoclass in the fileversion_info.py.The
enocean_example.pyfile has been changed to also display the chip id.In order for these changes it was necessary to slightly change the way, how the
Communicatorwaits for the response packet also in thebase_id()property.