Repository navigation
fix(playback): join stream failures to their release and request - #236
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A
Validation tasks: none
When a virtual direct-play stream fails, the failure names the session but not the release. The
virtual resolve timingline carries no request id, so it cannot join to its start or its provider fetch; the terminalvirtual_stream_unavailablenames the pinned candidate even after a heal or rotation served a sibling. Diagnosing a slow or failed first play takes timestamp forensics across three unjoined sources.Approach
Thread the start's edge request id into the resolve-timing line and log pinned vs delivered candidate identity on the proxy verdict and the terminal transport failure. Recovery behavior is unchanged: dispositions are log values only and no branch conditions moved. The delivered identity is passed explicitly (empty when nothing was served) because the catalog row still names the pin after a rotation.
Validation
go build ./...passes.gofmt -l internal/ cmd/prints nothing;git diff --checkclean.go veton touched packages passes;make lint-changedreports 0 issues.go teston the touched package passes (failure/cancel logging, proxy disposition and verdict, resolve timing, virtual direct-play serve).internal/api/handlerssuite not run to completion (exceeds local timeout; pre-existing large package).pnpm run lintpasses with pre-existing warnings only;pnpm run format:checkpasses.Risks
Logs only. One extra WARN per failed first proxy attempt even when a later heal or rotation recovers, so verdict warnings must not be counted as final playback failures. Client-canceled paths stay at DEBUG and remain invisible at the default opslog capture level.
Checklist
AI Disclosure