Repository navigation
fix(importer): keep failed imports out of completed history - #1002
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When content verification rejects an import, provisional history could still report it as Completed alongside its Failed queue entry. Keep the live queue authoritative, roll back provisional history on failure or deferral, and return empty storage paths for failed jobs and jobs without a storage path. This prevents a failed download from exposing the import root to Sonarr/Radarr.
Remove history before its owning queue row during deletion and failed-job retention, in a transaction, so the foreign key cannot orphan a false Completed record. Existing successful archived history remains available.
Closes #997.
Validation:
go vet, andgo buildpassed.PostgreSQL runtime and live Sonarr were not exercised. Already orphaned legacy records are preserved because they cannot safely be distinguished from successful archived imports. Existing macOS duplicate
-lc++linker warnings remain.