Repository navigation
fix(rclone): honor rcd restart tolerance duration - #995
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rcd health check now waits the configured restart tolerance before restarting. A 90-second tolerance requires four failed probes at 0, 30, 60, and 90 seconds; previously three probes triggered a restart after only 60 seconds. Duration rounding remains overflow-safe, and unset or invalid settings use the corrected 90-second fallback.
Closes #967.
Validation:
go test ./...,go test -race ./pkg/rclonecli -count=1, andgo vet ./pkg/rcloneclipassed.Timing remains rounded up to the 30-second monitoring interval. The pinned golangci-lint cannot decode Go 1.27 export data; lint validation remains unavailable locally.