You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This seems like an unusual way to fix this issue, I'm not sure I've really ever seen a package use the iife format as modern packages are usually isolated by default anyway. Is it possible to figure out what is conflicting and fix the way we are registering it in the code instead?
Current asset registration use this:
Js::make('commentions-scripts', DIR . '/../resources/dist/commentions.js')
Which will produce <script src=".."> and this is not isolated. all variables and functions are in global namespace.
Fix is to either use iife or update the asset registration to use module
Js::make('commentions-scripts', DIR . '/../resources/dist/commentions.js')->module()
This will produce <script src=".." type="module"> which is isolated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #86