Scope dependency-scan to shipping deps and make it blocking - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
dependency-scanjob was silently failing on every push. The overall CI run reported success only because the job was markedcontinue-on-error: true, so the red X was permanent noise.Root cause: the job dumped the entire Gradle dependency graph (all configurations, 282 packages) into a synthetic
pom.xmland fed it to OSV-scanner, which exits non-zero on any CVE. The 39 CVEs found (netty, logback, protobuf, commons-io) all live in build/test-only configurations:ktlinttestRuntimeOnlyNone reach
releaseRuntimeClasspath— the shipping closure is clean AndroidX/Kotlin/OkHttp.Fix
Scope the scan to only what actually ships:
:app+:unshorten→releaseRuntimeClasspath:core(JVM lib) →runtimeClasspathClosure drops 282 → 106 packages. Since the scan is now meaningful, the job is flipped from warn-only to blocking — it goes red only when a genuinely shipped dependency gets a CVE.
Verification
No issues found, exit 0actionlinton the workflow → clean