Remove remote section and all remote account management#3
Open
kitanoyoru wants to merge 1 commit into
Open
Conversation
- Remove Remote model types (RemoteAccount, RemoteUser, RemoteProfileDetail, ContributionGraph) - Remove remote HTTP services (GitHub, GitLab, Bitbucket services + RemoteKeyError) - Remove NetrcReader and KeychainManager utilities (only used by remote) - Strip all remote state, resolution, and CRUD from StatusViewModel - Remove remote section UI, screens, and provider badges from MenuBarView - Strip account persistence and migration from SettingsStore - Remove Accounts tab from SettingsView - Remove remote-related tests (RemoteAccount, ContributionGraph, RemoteUser, KeyNormalization, RemoteAddKeyRequest, NetrcReader)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Remote section and all related remote account management from kssh, keeping the app focused on its core purpose: SSH keys, Git profiles, and GPG keys.
Changes
Deleted files (10)
RemoteAccount.swift,RemoteUser.swift,RemoteProfileDetail.swift,ContributionGraph.swiftGitHubService.swift,GitLabService.swift,BitbucketService.swift,RemoteKeyError.swiftNetrcReader.swift,KeychainManager.swift(only used by remote)Modified files (5)
Result