Repository navigation
Conversation
Stop defaulting an empty unit to 'piece' in the products controller, send the cleared unit from the edit form so it actually gets removed, and don't carry over a stale unit when selecting a product without one in the invoice editor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow products without a unit
Closes #154
Problem
A product's unit couldn't be cleared:
"piece"when creating, updating and reading products.undefinedwhen the unit was cleared, so the backend kept the old value.Changes
backend/src/controllers/products.ts: removed the"piece"fallback. An empty unit is stored asNULLand returned asundefined.frontend/src/routes/products/[id]/edit/+page.server.ts: the form now sends the empty unit so the backend clears it.frontend/src/lib/components/InvoiceEditor.svelte: picking a product with no unit for an invoice line now clears that line's unit instead of keeping the previous one.Behaviour change
New products with no unit selected now have no unit; they no longer default to
piece. Existing products are not changed.Testing
-🤖 Generated with Claude Code