LambdaMART implementation with latest master rebase#82
LambdaMART implementation with latest master rebase#82srinikrish22 wants to merge 13 commits intokiudee:masterfrom
Conversation
kiudee
left a comment
There was a problem hiding this comment.
Thank you for the rebase.
Overall, the code improved a lot over the previous submission.
To finalize the submission, remember to:
- Currently, I am not able to use
predictwithout it throwing an error. This should be fixed. - Fix the issues remarked in the code.
- Execute the black code formatter on your files and on the functions you added. Try to avoid reformatting existing files.
- Add LambdaMART to https://github.com/kiudee/cs-ranking/blob/master/csrank/objectranking/__init__.py for direct import (
from csrank import LambdaMART).
…m/srinikrish22/cs-ranking into lambdamart-implementation-rebased
…unctions to the lambdamart file itself
Pull Request Test Coverage Report for Build 700
💛 - Coveralls |
|
Fixes have been made based on the suggested changes. I have also run the black code formatter. |
All the changes requested have been completed:
|
I have implemented the LambdaMART algorithm for object ranking. This branch has the latest rebase from the current master branch of cs-ranking.
Description
I have created a class with the required core functionality of lambdamart and added ndcg metric implementation to the utils. I have added the ranker into the test_ranking and also added the ranker definition in the constants.
Motivation and Context
This change aims at adding an implementation of a new ranker for object ranking to the repository.
How Has This Been Tested?
I have added the possibility to test this ranker under the existing testing infrastructure of the cs-ranking repository.
Does this close/impact existing issues?
Types of changes
Checklist: