Skip to content

Feat nxe phase - #20

Merged
kjdev merged 2 commits into
mainfrom
feat/nxe-phase
Sep 2, 2026
Merged

kjdev merged 2 commits into
mainfrom
feat/nxe-phase

Conversation

@kjdev

@kjdev kjdev commented Sep 2, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the execution order of OAuth2 token authentication handlers alongside other modules operating in the same request phases.
    • Improved consistency of authentication processing during access checks.
  • Build and Dependencies

    • Added the phase-handling component required to coordinate module execution order.
    • Updated build configuration to include the new component in packaged builds.

Add the nxe-phase submodule and register the PREACCESS/ACCESS phase
handlers through nxe_phase_add_handler() instead of a direct
ngx_array_push(). This fixes execution order relative to other
same-phase modules being dependent on --add-module/load_module order.
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: e6f249cf-4003-483b-958c-6ffc79344da7

📥 Commits

Reviewing files that changed from the base of the PR and between 1c97d55 and b723928.

📒 Files selected for processing (6)
  • .gitmodules
  • CHANGELOG.md
  • Dockerfile
  • config
  • nxe-phase
  • src/ngx_http_auth_oauth2_token_module.c

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Adds the nxe-phase submodule to the build and replaces direct nginx phase-handler insertion with prioritized nxe_phase_add_handler() calls for the PREACCESS and ACCESS handlers.

Changes

nxe-phase integration

Layer / File(s) Summary
nxe-phase build integration
.gitmodules, nxe-phase, config, Dockerfile
The build declares, copies, loads, and links the nxe-phase submodule.
Prioritized phase handler registration
src/ngx_http_auth_oauth2_token_module.c, CHANGELOG.md
The module registers both handlers with nxe_phase_add_handler() and NXE_PHASE_PRIO_OAUTH2_TOKEN. The changelog records the change.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b7239

The change is merge-ready after normal checks; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (5 skipped: 5 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the main change: adding nxe-phase support. It is concise and related to the pull request changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (5 skipped: 5 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/nxe-phase

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kjdev
kjdev merged commit b723928 into main Sep 2, 2026
8 checks passed
@kjdev
kjdev deleted the feat/nxe-phase branch September 2, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant