feat!: raise the VS Code floor to 1.136 - #61
Merged
Conversation
`@types/vscode` published 1.136.0, and `@kkdev92/vscode-ext-kit` 5.0.0 raised its own `engines.vscode` to `^1.136.0` in step with it. Every extension built on the kit inherits that floor, so this one declares it too, and takes the kit major. `vsce` enforces the pairing rather than trusting it: with `@types/vscode` at `~1.136.0` and `engines.vscode` left at `^1.134.0`, packaging fails outright with "@types/vscode ~1.136.0 greater than engines.vscode ^1.134.0". That is what the weekly dependency PR ran into -- across all six platform builds -- and raising the two together is the fix. Nothing this extension does changed. Pasting, saving and the image handling behave exactly as in 0.4.x; the only reason for a version is that installations on an older VS Code can no longer take updates. Verified: `npm run verify` end to end -- lint, compile, the test typecheck, the suite with coverage, and the e2e lane, which is 13 cases in a real Extension Host. Then `vsce package` (the step that was failing) and the VSIX verification. BREAKING CHANGE: VS Code 1.136 or later is now required. Installations on an older VS Code keep 0.4.x. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Uf34bXf9dd7BURuBCh7Wx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases 0.5.0. VS Code 1.136 or later is now required; nothing this extension
does changed.
Why
@types/vscodepublished 1.136.0, and@kkdev92/vscode-ext-kit5.0.0 raised itsown
engines.vscodeto^1.136.0in step with it. Every extension built on thekit inherits that floor.
vsceenforces the pairing rather than trusting it. With@types/vscodeat~1.136.0andengines.vscodeleft at^1.134.0, packaging fails outright:That is exactly what the weekly dependency pull request ran into, and because
this extension ships six platform-specific builds, it failed on all six.
Nothing else changed
Pasting, saving and the image handling behave exactly as in 0.4.x. The only
reason a version exists is that installations on an older VS Code can no longer
take updates — they keep 0.4.x.
The kit major it takes is equally narrow: 5.0.0 raised the floor and nothing
else, and the API it exposes is byte-for-byte what 4.1.1 exposed.
Verification
npm run verifyend to end — lint, compile, the test typecheck, the suitewith coverage, and the e2e lane, which is 13 cases in a real Extension
Host, so the new floor was exercised against a host that has it
vsce package— the step that was failing, now packaging 116 files🤖 Generated with Claude Code