chore(deps-dev): take vitest 5 and coverage-v8 5 together - #64
Merged
Conversation
Dependabot opened these as two pull requests, and neither could merge alone: `@vitest/coverage-v8` pins `vitest` exactly, so bumping either one on its own fails `npm ci` with ERESOLVE. Together they resolve cleanly. vitest 5 was measured against this repository rather than assumed, because the two sibling extensions are staying on 4.x -- there, the kit's published Vitest surface stops sharing a module instance with the test file under 5, and six integration tests see an empty mock. This repository does not use that surface: `test/setup.ts` mocks `vscode` itself, and `vitest.config.ts` inlines the kit so the mock reaches the kit's own imports. That difference is why the result differs, and why the sibling finding was not carried over. Verified: the whole `verify` lane on vitest 5 -- lint, compile, the test typecheck, 453 tests with coverage, and the e2e lane, which is 13 cases in a real Extension Host. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Uf34bXf9dd7BURuBCh7Wx
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #63 and #62, which cannot merge separately.
Why one pull request
@vitest/coverage-v8pinsvitestexactly, so either bump alone failsnpm ci:That is why both of Dependabot's pull requests are red. Together they resolve cleanly.
Why this repository takes vitest 5 when the siblings do not
quick-utils and plantuml-local are holding at 4.x, because there the kit's published Vitest surface (
@kkdev92/vscode-ext-kit/testing/vitest) stops sharing a module instance with the test file under vitest 5 — six integration tests see a mock that recorded nothing.This repository does not use that surface.
test/setup.tsmocksvscodeitself, andvitest.config.tsalready inlines the kit so the mock reaches the kit's own imports. The sibling result was measured here rather than assumed, and it does not reproduce.Verification
The whole
verifylane on vitest 5:🤖 Generated with Claude Code