Skip to content

Fix ICMP Ping Bursts via Randomized Jitter #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kljama merged 1 commit into from
Jul 31, 2026
Merged

Fix ICMP Ping Bursts via Randomized Jitter #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions internal/monitoring/pinger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ package monitoring

import (
"context"
"crypto/rand"
"fmt"
"math/big"
"net"
"strings"
"sync"
Expand Down Expand Up @@ -51,8 +53,22 @@ func StartPinger(ctx context.Context, wg *sync.WaitGroup, device state.Device, i
pingOp = performPing
}

// Initialize timer for first ping with 1 second delay to avoid immediate ping storm
timer := time.NewTimer(1 * time.Second)
// Initialize timer for first ping with jitter to avoid immediate ping storm
// Jitter is random between 0 and interval to spread out initial bursts
initialDelay := 1 * time.Second
if interval > 0 {
val, err := rand.Int(rand.Reader, big.NewInt(int64(interval)))
if err == nil {
initialDelay = time.Duration(val.Int64())
} else {
log.Warn().
Str("ip", device.IP).
Err(err).
Msg("Failed to generate random initial delay, using default 1s fallback")
}
}

timer := time.NewTimer(initialDelay)
defer timer.Stop()

for {
Expand Down
Loading